add framework tests (i.e. vitest)#1349
add framework tests (i.e. vitest)#1349ibolmo wants to merge 2 commits intoibolmo/bra-4115-braintrust-eval-should-work-with-evals-with-top-level-awaitfrom
Conversation
ibolmo
changed the base branch from
main
to
ibolmo/bra-4115-braintrust-eval-should-work-with-evals-with-top-level-await
| // Top-level await - ESM-only feature | ||
| // This proves Deno can handle async module evaluation | ||
| const config = await Promise.resolve({ prefix: "Result: " }); |
There was a problem hiding this comment.
does this need to be duplicated for each runtime? or can we make the runtime a separate axis?
There was a problem hiding this comment.
i'd skip the framework tests (and this draft PR). it's mostly unreviewed slop i wanted to separate from the main PR: #1347
it is possible to have a shared tests like we do with smoke, but wanted to get something going first. i think that's what you mean by avoiding the duplication?
There was a problem hiding this comment.
even in that change there are several instances of essentially the same file, https://github.com/braintrustdata/braintrust-sdk/pull/1347/changes#diff-a294c96468f18c6afc2645b696eeb0dc99b74ae03ca2ec61d8d8238f125c5b31
There was a problem hiding this comment.
yeah totally. just wanted to get something up, but i'll cleanup/optimize before merging that.
ibolmo
force-pushed
the
ibolmo/bra-4115-braintrust-eval-should-work-with-evals-with-top-level-await
branch
from
1c2b7f0 to
e0d8601
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If this PR is still relevant, please leave a comment, push an update, or remove the stale label. Thank you for your contributions! |
2 participants
this should eventually help answer do our evals work in
vitest,jestetc.